Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Rector from making service properties nullable #13

Open
DieterHolvoet opened this issue Mar 16, 2021 · 0 comments
Open

Stop Rector from making service properties nullable #13

DieterHolvoet opened this issue Mar 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@DieterHolvoet
Copy link
Contributor

Summary

When the dependencies of a class are injected using ContainerFactoryInterface or ContainerFactoryPluginInterface, the property types of the services are now always nullable and assigned a null value. It's same to assume these properties will never under normal circumstances be null, so they shouldn't be made nullable.
@DieterHolvoet DieterHolvoet added the enhancement New feature or request label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DieterHolvoet