Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Parameterless Stopping Criteria #159

Closed
william-dawson opened this issue Oct 23, 2020 · 1 comment
Closed

Implement Parameterless Stopping Criteria #159

william-dawson opened this issue Oct 23, 2020 · 1 comment
Assignees

Comments

@william-dawson
Copy link
Owner

https://pubs.acs.org/doi/full/10.1021/acs.jctc.6b00626

I've tested this out so far and it seems really nice. It will definitely make it easier to integrate the code since you don't need to manage the convergence criteria yourself. The following steps will need to be taken:

  1. Add the option to the solver parameters.
  2. Implement for SP2. This is the easiest because the pseudocode is right the in the manuscript.
  3. Implement for Scale and Fold. This is also in the manuscript, but is maybe more tricky.
  4. Derive criteria for the other solvers. Write a Wiki page with this info.
  5. Implement for the other solvers.
@william-dawson
Copy link
Owner Author

While I suspect the method of Kruchinina is surely superior for specific cases, the automatic convergence monitoring of #218 seems good enough and can be added to any solver without technical work. So for now this is closed, but worth revisiting someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant