Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write DOD #918

Closed
jolly12f opened this issue Jun 8, 2024 · 2 comments
Closed

Write DOD #918

jolly12f opened this issue Jun 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jolly12f
Copy link

jolly12f commented Jun 8, 2024

Description

I would like to know if it is possible to add a box to set the DOD

Suggested Solution

Set a checkbox to enter DOD percentage in sofar inverter

Alternatives

No

Additional Context

No

@jolly12f jolly12f added the enhancement New feature or request label Jun 8, 2024
@cschlipf
Copy link
Contributor

cschlipf commented Aug 7, 2024

Duplicate of #703

In theory yes, in practice no. The problem is that Sofar often requires to write a lot of registers in one chunk. In case of the DoD it's a very large chunk that includes a lot of very critical battery parameters.

Now we could read these parameters and set them again - however if there is any read error on one of the critical parameters, we are potentially setting very harmful values. This is too risky.

See also the discussion on #703

@wills106
Copy link
Owner

wills106 commented Aug 7, 2024

Closing due to being a duplicate Issue

@wills106 wills106 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants