Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imageWidth/imageHeight filters not available on cold cache #1120

Open
matteotrubini opened this issue May 7, 2024 · 1 comment
Open

imageWidth/imageHeight filters not available on cold cache #1120

matteotrubini opened this issue May 7, 2024 · 1 comment
Labels
help wanted Issues/PRs that are good candidates for new contributors to look into needs response Issues/PRs where a maintainer is awaiting a response from the submitter
Milestone
1.2.8

Comments

@matteotrubini
Copy link
Contributor

Package targeted

Winter CMS

Description

Twig filters | imageWidth and | imageHeight are not working until the resized image is generated (on cold cache) as they fail to manage /resizer/* url resource.

When the filter are applied to a /resizer/* resource, ImageResizer::filterGetDimensions() should calculate and return valid values (using the stored configuration?).

Will this change be backwards-compatible?

No breaking changes expected.
@matteotrubini matteotrubini added needs review Issues/PRs that require a review from a maintainer Type: Conceptual Enhancement labels May 7, 2024
@LukeTowers LukeTowers added Type: Bug help wanted Issues/PRs that are good candidates for new contributors to look into and removed Type: Conceptual Enhancement labels May 7, 2024
@LukeTowers LukeTowers added this to the 1.2.7 milestone May 7, 2024
@LukeTowers LukeTowers modified the milestones: 1.2.7, 1.2.8 Jul 22, 2024
@LukeTowers
Copy link
Member

@matteotrubini any ideas for an implementation for this?

@bennothommo bennothommo added needs response Issues/PRs where a maintainer is awaiting a response from the submitter and removed needs review Issues/PRs that require a review from a maintainer labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues/PRs that are good candidates for new contributors to look into needs response Issues/PRs where a maintainer is awaiting a response from the submitter
Projects
None yet
Milestone
1.2.8
Development

No branches or pull requests
3 participants
@LukeTowers @matteotrubini @bennothommo