Improved Tailwind Config Docs #417
rishabkapadia
started this conversation in
General
Replies: 1 comment
-
Thanks, updated the readme. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Reason: To save time for those not well versed with tailwind config file.
By default, the modal view uses
2xl
as mentioned in theModalComponent.php
file undermodalMaxWidth()
method.Also the docs mention to add the
sm:max-w-2xl
in the safelist.But when I tried to return for eg.
4xl
from themodalMaxWidth()
in custom livewire component and add below code block to safelist it doesn't work.That is because the
ModalComponent.php
mapsxl
,2xl
, etc width to a list of classes which the user needs to add in the safelist. for eg. for4xl
:sm:max-w-md md:max-w-xl lg:max-w-3xl xl:max-w-4xl
Below seems like a better alternative to cover all the class combinations to make it work for various modal sizes used in a project:
ref:
https://tailwindcss.com/docs/content-configuration#using-regular-expressions
Would be great if this code block could be added to the Docs instead of just mentioning
sm:max-w-2xl
in the safelist.Beta Was this translation helpful? Give feedback.
All reactions