-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds automatic, seasonally appropriate messages from Houston #9476
Conversation
🦋 Changeset detectedLatest commit: 39f74b4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really fun! I'm glad we won't have to manually manage these messages anymore.
A few suggested refactors to organize things a bit better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for implementing this!
Changes
data/seasonal.ts
file that implements seasonally appropriate messages and decorationsTesting
Tested locally and regressions are covered by the existing tests!
Docs
No docs