Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Password hashing does not work on all node runtimes #74

Closed
Adammatthiesen opened this issue May 10, 2024 · 1 comment · Fixed by #75
Closed

Bug: Password hashing does not work on all node runtimes #74

Adammatthiesen opened this issue May 10, 2024 · 1 comment · Fixed by #75
Assignees
@Adammatthiesen
Labels
bug Something isn't working enhancement New feature or request

Comments

@Adammatthiesen
Copy link
Member

napi-rs/node-rs#816

This same error is present when username/password is enabled for deployments, to resolve this we should swap the node-rs/argon dep to a package such as noble-hashes as a runtime agnostic alternative for password hashing.
@Adammatthiesen Adammatthiesen added bug Something isn't working enhancement New feature or request labels May 10, 2024
@Adammatthiesen Adammatthiesen self-assigned this May 10, 2024
@create-issue-branch Create Issue Branch
Copy link
Contributor

Branch issue-0074 created for issue: Bug: Password hashing does not work on all node runtimes

create-issue-branch bot added a commit that referenced this issue May 10, 2024
@create-issue-branch
Create draft PR for #74
1045f17 
[skip ci]
@create-issue-branch create-issue-branch bot mentioned this issue May 10, 2024
Merged
@Adammatthiesen Adammatthiesen moved this from Todo to In Progress in StudioCMS Roadmap to First Release May 10, 2024
@Adammatthiesen Adammatthiesen moved this from In Progress to Done in StudioCMS Roadmap to First Release May 10, 2024
@Adammatthiesen Adammatthiesen moved this from Done to In Progress in StudioCMS Roadmap to First Release May 10, 2024
Adammatthiesen added a commit that referenced this issue May 10, 2024
@create-issue-branch @Adammatthiesen
✨ Bug: Password hashing does not work on all node runtimes (#75)
27c654a 
* Create draft PR for #74
[skip ci]

* update and fix username and password auth

* remove unused imports

---------

Co-authored-by: create-issue-branch[bot] <53036503+create-issue-branch[bot]@users.noreply.github.com>
Co-authored-by: Adam Matthiesen <amatthiesen@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adammatthiesen Adammatthiesen

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Bug: Password hashing does not work on all node runtimes withstudiocms/studiocms
1 participant
@Adammatthiesen