Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optional label in witnet.proto field #2443

Open
drcpu-github opened this issue Mar 22, 2024 · 0 comments
Open

Remove optional label in witnet.proto field #2443

drcpu-github opened this issue Mar 22, 2024 · 0 comments
Labels
2.0 enhancement 📈 New feature or request good first issue 👋 Good for newcomers

Comments

@drcpu-github
Copy link
Collaborator

There is an optional field in witnet.proto which should not be necessary as all fields are optional by default. Rustc 1.77 even refuses to build this:

witnet.proto:304:14: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 enhancement 📈 New feature or request good first issue 👋 Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aesedepece @drcpu-github