Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I'm adding 2 musicians who are different people but have the same name, it does not allow it #1

Open
wjayee opened this issue Nov 17, 2023 · 1 comment

Comments

@wjayee
Copy link
Owner

wjayee commented Nov 17, 2023

It is possible that 2 separate people have the same name, so it may not be good to check for duplicates using name
name bug.png

@soc-se-bot
Copy link

soc-se-bot commented Nov 20, 2023

Team's Response

Thank you for your suggestion. However, in our current implementation, the UniqueMusicianList is a crucial class that enforces uniqueness of musician names and forms the crux of many other functions in BandConnect.

While this unlikely scenario is possible to happen, it should not cause much inconvenience to users. Furthermore, allowing duplicate names will result in many other implementation issues that are beyond the scope of v1.4.

In the meantime, one could still circumvent this problem by inputting differentiators such as John Doe Piano and John Doe Violin, which will be treated as two distinct names.

We hope you understand our decision to classify this issue as NotInScope. Please let us know if you have any further queries.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants