Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See how we could work together with python-tado from erwindouna #116

Open
wmalgadey opened this issue Dec 23, 2024 · 5 comments
Open

See how we could work together with python-tado from erwindouna #116

wmalgadey opened this issue Dec 23, 2024 · 5 comments

Comments

@wmalgadey
Copy link
Owner

wmalgadey commented Dec 23, 2024

I already asked this question in erwindouna/python-tado#97.

I think we should decide, whether to

  • rewrite the home assistant Tado integration and use erwindouna's rewrite (this would make PyTado for me rather obsolete, because I did my changes only, because I need it in homeassistant)
  • or resolve Add tado X support #86
@wmalgadey
Copy link
Owner Author

home-assistant/core#132070 (comment):

There's a new library in the making and currently the Tado X only are supported via the custom component.
A long awaited upgrade is on its way.

@Moritz-Schmidt
Copy link

I think there are good arguments for both options. I think with the work @wmalgadey did the past few days this library is on a good path to supporting TadoX. But async support and stricter typing – which @erwindouna did in their rewrite – is also relevant. I think async could be done in this library too but it'd need some more work. Stricter typing can be accomplished in this library as well and I think it can be done in the near future.

No matter if or what library we want to focus the effort on I'd be happy to help!

Since TadoX support here is already further in the development and the home assistant library wouldn't need (almost) complete rewrite I'd favor focusing the effort here but I think some things like the typing of the Tado API responses from @erwindouna 's repo could be useful here too.

@erwindouna
Copy link
Collaborator

We're joining forces to create a robust and modern API for Tado. Typing can be added relative easily. For some parts I have a few ideas to restructure the library a bit, but I will put this up for proper discussions in PR's.

Personally I think we should and can offer a hybrid form of async. Support the synchronize parts to remain backwards compatibility and async methods in the near future. Httpx is a good library to replace requests. Any feedback on this idea?

@erwindouna
Copy link
Collaborator

Note: In a separate email chain, @wmalgadey and myself aligned we'll continue the efforts within PyTado.

@Moritz-Schmidt
Copy link

Sounds good to me! I have some Ideas as well which I'll also properly discuss in PR's. Thanks for the Information that efforts will be continued here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants