-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
See how we could work together with python-tado from erwindouna #116
Comments
home-assistant/core#132070 (comment):
|
I think there are good arguments for both options. I think with the work @wmalgadey did the past few days this library is on a good path to supporting TadoX. But async support and stricter typing – which @erwindouna did in their rewrite – is also relevant. I think async could be done in this library too but it'd need some more work. Stricter typing can be accomplished in this library as well and I think it can be done in the near future. No matter if or what library we want to focus the effort on I'd be happy to help! Since TadoX support here is already further in the development and the home assistant library wouldn't need (almost) complete rewrite I'd favor focusing the effort here but I think some things like the typing of the Tado API responses from @erwindouna 's repo could be useful here too. |
We're joining forces to create a robust and modern API for Tado. Typing can be added relative easily. For some parts I have a few ideas to restructure the library a bit, but I will put this up for proper discussions in PR's. Personally I think we should and can offer a hybrid form of async. Support the synchronize parts to remain backwards compatibility and async methods in the near future. Httpx is a good library to replace requests. Any feedback on this idea? |
Note: In a separate email chain, @wmalgadey and myself aligned we'll continue the efforts within PyTado. |
Sounds good to me! I have some Ideas as well which I'll also properly discuss in PR's. Thanks for the Information that efforts will be continued here. |
I already asked this question in erwindouna/python-tado#97.
I think we should decide, whether to
The text was updated successfully, but these errors were encountered: