Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The codes.wmo.int-49-2-AerodromeRecentWeather.rdf files in several IWXXM versions published at https://schemas.wmo.int/iwxxm/ do not contain RERASN #328

Open
jkorosi opened this issue Feb 1, 2024 · 2 comments

Comments

@jkorosi
Copy link

jkorosi commented Feb 1, 2024

Describe the bug
The codes.wmo.int-49-2-AerodromeRecentWeather.rdf files in several IWXXM versions published at https://schemas.wmo.int/iwxxm/ do not contain RERASN (https://codes.wmo.int/49-2/AerodromeRecentWeather/_RERASN that is mapped to http://codes.wmo.int/306/4678/RASN). RERASN was added to the code registry in #74 in IWXXM 2.1.1.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
All mentioned RDF files should contain

<skos:member>
  <skos:Concept rdf:about="http://codes.wmo.int/306/4678/RASN">
    <rdfs:label xml:lang="en">Precipitation of rain and snow</rdfs:label>
  </skos:Concept>
</skos:member>

Screenshots

Desktop (please complete the following information):

Additional context

@amilan17 amilan17 assigned amilan17 and unassigned amilan17 Feb 28, 2024
@amilan17
Copy link
Member

amilan17 commented Feb 28, 2024

a possible solution:
add a note to the previous Releases, indicating that an RDF file was missing a code and it's been added to that version at schemas.wmo.int

@blchoy
Copy link
Member

blchoy commented Mar 26, 2024

Checking the file codes.wmo.int-49-2-AerodromeRecentWeather.rdf in various locations, including schemas.wmo.int as well as my own SVN:

  1. IWXXM 2.1.1: RASN is missing on schemas.wmo.int but is there on my own SVN
  2. IWXXM 3.0.0: codes.wmo.int-49-2-AerodromeRecentWeather.rdf is not available on schemas.wmo.int, and RASN is missing on my own SVN
  3. IWXXM 2021-2 and 2023-1: RASN is missing on both schemas.wmo.int and on my own SVN

So the likely scenario is that:

  1. IWXXM 2.1.1 was published in Nov 2017. During development RASN was added manually to codes.wmo.int-49-2-AerodromeRecentWeather.rdf on my SVN but not (yet) on codes.wmo.int. When publishing on schemas.wmo.int, the RDFs were collected directly from codes.wmo.int. Hence RASN was missing on schemas.wmo.int.
  2. RASN was introduced to codes.wmo.int-49-2-AerodromeRecentWeather.rdf on codes.wmo.int in Apr 2018.
  3. In developing IWXXM 3.0.0RC1 in 2018 we were using the RDFs directly from schemas.wmo.int without using the latest versions from codes.wmo.int. These RDFs were never refreshed from codes.wmo.int since then.

Now the CI script codeListsToSchematron.py is intended to download RDFs from codes.wmo.int if they are not there. However, if an RDF does exist the download will be skipped. It seems to me that downloading should only be skipped if the ones on the repository is the same as those on codes.wmo.int.

A separate issue will be raised to deal with the refinement of codeListsToSchematron.py.

I agree with @amilan17's suggestion to (1) update codes.wmo.int-49-2-AerodromeRecentWeather.rdf for IWXXM versions 2.1.1, 2021-2 and 2023-1 on schemas.wmo.int (note that if there are zip files they should also be updated), and (2) put a note in the respective releases on GitHub saying that this file has been updated and if one downloaded the releases they should refer to schemas.wmo.int for the correct version of codes.wmo.int-49-2-AerodromeRecentWeather.rdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants