Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Default really be required for qml_register_singleton_instance? #243

Open
mullr opened this issue Feb 6, 2022 · 0 comments
Open

Should Default really be required for qml_register_singleton_instance? #243

mullr opened this issue Feb 6, 2022 · 0 comments

Comments

@mullr
Copy link

mullr commented Feb 6, 2022

The signature currently looks like this:
pub fn qml_register_singleton_instance<T: QObject + Sized + Default>

But it doesn't make sense to me why Default would be required there, and the implementation doesn't seem to use it at all. Perhaps this is a copy-paste bug, from qml_register_singleton_type?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mullr