Add null QVariant constructor #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
direc85
force-pushed
the
null-qvariant
branch
2 times, most recently
from
e26c6b0
to
9fe1dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QVariant::default()yields anundefinedvalue in QML, but in many places anullvalue is more suited. AddQVariant::null()function to achieve that. The test added help distinguishing this.I would have used
QVariant(nullptr)instead, but that doesn't seem to work well with the type system in Qt5. TheQJsonValue().toVariant()is the next best option - and makes sense, since a JSON can also have an explicitnullvalue.