Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for critical extension check following RFC 5280 4.2.2.1 #5636

Closed
wants to merge 3 commits into from

Conversation

Keinahas
Copy link

Description

Problem:

  • RFC 5280 4.2.2.1 Says Conforming CAs MUST mark Authority Information Access Extension as non-critical.
  • Description of function DecodeAuthKeyId had wrong section (RFC 5280 4.2.2.1 - AuthInfo)
  • Description of function DecodeSubjKeyId had wrong section (RFC 5280 4.2.2.1 - AuthInfo)
  • Description of function DecodeKeyUsage had wrong section (RFC 5280 4.2.2.1 - AuthInfo)

Fix:

  • added Critical check of Authority Information Access Extension in function DecodeExtensionType
  • fixed Description of function DecodeAuthKeyId to RFC 5280 4.2.1.1 - Authority Key Identifier
  • fixed Description of function DecodeSubjKeyId to RFC 5280 4.2.1.2 - Subject Key Identifier
  • fixed Description of function DecodeKeyUsage to RFC 5280 4.2.1.3 - Key Usage
  • added AuthInfo fix to Changelog

Fixes #5635

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

RFC 5280 4.2.2.1 Says Conforming CAs MUST mark Authority Information Access Extension as non-critical.
4.2.1.3 - Key Usage
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@embhorn embhorn self-assigned this Sep 27, 2022
@embhorn
Copy link
Member

embhorn commented Sep 27, 2022

Hi @Keinahas

Thanks for these improvements!

We do not typically accept small changes from new contributors. Do you anticipate making more changes in the wolfSSL project? If not I can open a new PR to incorporate these fixes.

Otherwise please send an email referencing this PR to support@wolfssl.com requesting a Contributor Agreement form.

Thanks,
@embhorn
wolfSSL Support

@embhorn
Copy link
Member

embhorn commented Jul 24, 2023

Closing in favor of #6646

@embhorn embhorn closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not following RFC5280 for Authority Information Access extension.
3 participants