Moved CertManager APIs into own file #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
certman_split
branch
4 times, most recently
from
758718c
to
a5f461b
Compare
dgarske
previously approved these changes
Jul 7, 2023
| byte *response, int responseSz, WOLFSSL_BUFFER_INFO *responseBuffer, | ||
| CertStatus *status, OcspEntry *entry, OcspRequest *ocspRequest); | ||
| WOLFSSL_API int wolfSSL_CertManagerCheckOCSPResponse( | ||
| WOLFSSL_CERT_MANAGER* cm, unsigned char *response, int responseSz, |
There was a problem hiding this comment.
Thanks for changing the byte to unsigned char type in ssl.h to match ssl.h pattern! Just making note of it, we should probably follow up with catching any other byte/word32 uses in ssl.h between now and the next release to have them all handled.
JacobBarthelmeh
previously approved these changes
Jul 7, 2023
dgarske
previously approved these changes
Jul 7, 2023
Split out certificate manager APIs into ssl_certman.c. ssl.c includes ssl_certman.c Better test coverage. Minor fixes. wolfSSL_X509_chain_up_ref calls XFREE with name->heap but name may be NULL. Check for NULL first.
…tests for bad date check. Various spelling fixes.
DecodeCertInternal was not recognizing VERIFY_SKIP_DATE.
JacobBarthelmeh
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split out certificate manager APIs into ssl_certman.c. ssl.c includes ssl_certman.c
Better test coverage.
Minor fixes.
wolfSSL_X509_chain_up_ref calls XFREE with name->heap but name may be NULL. Check for NULL first.
Testing
Tested different configurations affecting Certificate Manager code.
Checklist