Add CRL_REPORT_LOAD_ERRORS option #6591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmael
requested changes
Jul 20, 2023
src/crl.c
Outdated
| if (!skip && ProcessFile(NULL, name, type, CRL_TYPE, NULL, 0, crl, | ||
| VERIFY) != WOLFSSL_SUCCESS) { | ||
| WOLFSSL_MSG("CRL file load failed, continuing"); | ||
| } | ||
| #else | ||
| if (!skip) { | ||
| int temp = ProcessFile(NULL, name, type, CRL_TYPE, NULL, 0, crl, |
There was a problem hiding this comment.
Consider using ret instead of creating a new int temp. Everything else looks good.
tmael
reviewed
Jul 21, 2023
src/crl.c
Outdated
| ret = ProcessFile(NULL, name, type, CRL_TYPE, NULL, 0, crl, VERIFY); | ||
| if (ret != WOLFSSL_SUCCESS) { | ||
| WOLFSSL_MSG("CRL file load failed"); | ||
| return(ret); |
There was a problem hiding this comment.
use return ret; for consistency with the rest of the code
tmael
previously approved these changes
Jul 21, 2023
tmael
approved these changes
Jul 21, 2023
JacobBarthelmeh
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
CRL_REPORT_LOAD_ERRORSis defined at compile time, any error encountered when loading CRL's will be returned.Fixes zd16296
Testing
Customer confirmed.
Automated tests will fail with
CRL_REPORT_LOAD_ERRORSsince CRL tests include invalid CRL's.Checklist