Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple "universal binary framework" build script and project example #6610

Merged
merged 8 commits into from
Jul 19, 2023

Conversation

bigbrett
Copy link
Contributor

Description

Adds a script that shows how to build a "universal binary" library framework for all Apple devices that can be easily imported into a a multi-platform Xcode project. It also includes an example swiftUI application that calls a C driver function wolfCrypt tests and runs a simple TLS example

Gory details and demo app instructions can be found in the README

I added this to the IDE directory, but let me know if it should instead belong to another place or in another repo

@bigbrett bigbrett requested a review from dgarske July 13, 2023 19:01
@bigbrett
Copy link
Contributor Author

@dgarske added license header to the build script and swift files too, let me know if that is excessive and I can remove.

@bigbrett bigbrett requested a review from dgarske July 13, 2023 22:33
dgarske
dgarske previously approved these changes Jul 13, 2023
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have in the dist bundle for users, please update a include.am file for make dist

@JacobBarthelmeh JacobBarthelmeh removed their assignment Jul 14, 2023
@bigbrett
Copy link
Contributor Author

would be nice to have in the dist bundle for users, please update a include.am file for make dist

@JacobBarthelmeh done

Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran the Jenkins tests, they look ok just the status did not get updated.

Thanks Brett!

…, removed curl and harden default options, updated documentation
@bigbrett
Copy link
Contributor Author

Added support for passing additional options to configure on the command line

@JacobBarthelmeh
Copy link
Contributor

Added support for passing additional options to configure on the command line

Tested running the script with an added --enable- and it picked it up. Thanks Brett!

@JacobBarthelmeh JacobBarthelmeh merged commit b7b4be8 into wolfSSL:master Jul 19, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants