Add enable provider #7550
Merged
Add enable provider #7550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandi13
force-pushed
the
addEnableProvider
branch
from
bdc9d79
to
98cb850
Compare
|
retest this please |
bandi13
force-pushed
the
addEnableProvider
branch
from
98cb850
to
e340e41
Compare
The discrepancy shows up when trying to compile with FIPS
bandi13
force-pushed
the
addEnableProvider
branch
from
e075220
to
7cc42d4
Compare
douzzer
requested changes
Jul 12, 2024
configure.ac
Outdated
Comment on lines
333
to
337
| enable_all_crypto=yes | ||
| enable_opensslcoexist=yes | ||
| enable_sha=yes | ||
| enable_eccminsz=192 | ||
| with_max_ecc_bits=1024 |
There was a problem hiding this comment.
These should be conditional on the user not supplying an override value to configure. E.g.
test -z "$enable_all_crypto" && enable_all_crypto=yes
Notice that --enable-all, --enable-all-crypto, and even FIPS dev or v5-dev, use similar logic to allow tailoring and testing of different feature combinations. It's understood that some combinations won't work -- if the user forces something, they own the consequences.
douzzer
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up how ECC_MIN_SZ gets set. Added in '--enable-wolfprovider' option.