Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage for hpke.c test case HAVE_CURVE448 using test.c #7570

Merged
merged 3 commits into from
May 23, 2024

Conversation

jackctj117
Copy link

Description

Goal was to have code coverage for the HAVE_CURVE448 case in hpke.c, I achieved this by adding a new test case into test.c that hit those lines of code in hpke.c.

@jackctj117 jackctj117 self-assigned this May 22, 2024
wolfcrypt/test/test.c Show resolved Hide resolved
wolfcrypt/test/test.c Show resolved Hide resolved
wolfcrypt/test/test.c Show resolved Hide resolved
wolfcrypt/test/test.c Show resolved Hide resolved
wolfcrypt/test/test.c Show resolved Hide resolved
wolfcrypt/test/test.c Show resolved Hide resolved
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I am assigning these HPKE test coverage PR's over to @cconlon to determine the best way to merge each interns work.

@dgarske dgarske assigned cconlon and unassigned wolfSSL-Bot and jackctj117 May 23, 2024
@cconlon cconlon merged commit e05dbd5 into wolfSSL:master May 23, 2024
105 checks passed
aidangarske pushed a commit to aidangarske/wolfssl that referenced this pull request May 23, 2024
@aidangarske aidangarske mentioned this pull request May 23, 2024
4 tasks
dgarske added a commit that referenced this pull request May 24, 2024
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Code Coverage for hpke.c test case HAVE_CURVE448 using test.c
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants