Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc a buffer for NULL pointer #7646

Merged
merged 1 commit into from
Jun 18, 2024
Merged

alloc a buffer for NULL pointer #7646

merged 1 commit into from
Jun 18, 2024

Conversation

kojo1
Copy link
Contributor

@kojo1 kojo1 commented Jun 14, 2024

Description

allocate a buff when *pp is NULL for OpenSSL compatibility
Guarded by WOLFSSL_I2D_ECDSA_SIG_ALLOC for the backward compatibilitiy.

Fixes zd#17695

Testing

Added the case in test_wolfSSL_ECDSA_SIG

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@kojo1 kojo1 changed the title alloc a buff for NULL pointer alloc a buffer for NULL pointer Jun 14, 2024
@kojo1 kojo1 requested a review from wolfSSL-Bot June 14, 2024 23:37
Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting changes to match rest of file.

src/pk.c Outdated Show resolved Hide resolved
src/pk.c Outdated Show resolved Hide resolved
src/pk.c Outdated Show resolved Hide resolved
@SparkiDev SparkiDev merged commit c91d306 into wolfSSL:master Jun 18, 2024
117 checks passed
@SparkiDev SparkiDev assigned SparkiDev and unassigned kojo1 Jun 18, 2024
kojo1 added a commit to kojo1/wolfssl that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants