Properly handling the shutdown when multiple ones go on EAGAIN back to back #7881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
previously requested changes
Aug 16, 2024
src/internal.c
Outdated
| * We check if we are trying to send a | ||
| * CLOSE_NOTIFY alert | ||
| * */ | ||
| if (type == 0) { |
SparkiDev
previously requested changes
Aug 19, 2024
| if (type == 0) { | ||
| if (!ssl->options.sentNotify) { | ||
| ssl->options.sentNotify = 1; | ||
| } else { |
|
retest this please |
- added unit test; - formatting;
gasbytes
force-pushed
the
eagain-proper-shutdown
branch
from
12fe37b
to
577cce6
Compare
|
retest this please |
|
retest this please |
douzzer
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inhibit queueing redundant CLOSE_NOTIFY messages.
Fixes 7784
Testing
./testsuite/testsuite.testChecklist