Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RSA_MIN_SIZE default to 2048 bits #7923

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented Aug 29, 2024

Description

Increase the minimum RSA size for generating keys to 2048 bits.

Testing

Updated tests for new minimum. Will add config tests for RSA 1024 bit keys.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@embhorn
Copy link
Member Author

embhorn commented Sep 13, 2024

Retest this please

�[1;38;5;243mTesting configuration:�[0m
�[1;38;5;243m--enable-inline�[0m
Testing DEFAULT: --enable-inline
[Pipeline] script
[Pipeline] {
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // catchError
[Pipeline] sh
make[4]: *** [Makefile:8887: test-suite.log] Error 1
make[3]: *** [Makefile:8995: check-TESTS] Error 2
make[2]: *** [Makefile:9239: check-am] Error 2
make[1]: *** [Makefile:8772: check-recursive] Error 1
make: *** [Makefile:9241: check] Error 2
�[1;38;5;243mFailure details:�[0m

@embhorn embhorn assigned SparkiDev and unassigned embhorn Sep 13, 2024
@SparkiDev SparkiDev merged commit e6b466d into wolfSSL:master Sep 16, 2024
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants