20240910-configure-enable-all-asm-and-sp-cleanup #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Get sp_cortexm.c generation working and I'll review. |
|
retest this please ("google test" glitched) |
|
retest this please (post-testing#781 merge) |
…enable-all-crypto.
…lied to configure.
…r enable-all-crypto, and compute DEFAULT_ENABLED_ALL_ASM appropriately.
* in handling for enable-all-asm, add check for full Gnu C and don't auto-enable all-asm unless full Gnu C and enable-all-crypto, among other sanity checks. * in enable-all and enable-all-crypto, correctly conditionalize several FIPS-v6-only features/algorithms. * in FIPS v5 setup, force off SRTP and SRTP-KDF (with warnings).
…rch64, and enable sp-asm only for them, to avoid "ASM not available for CPU" error from sp-asm handler.
* move leanpsk and asn option processing early to make their results available to existing math back end selector logic; * add -DWOLFSSL_ASN_ALL to enable-all-crypto; * tweak asn option processing to preserve "original" value in case later configure logic wants to pivot on that.
douzzer
force-pushed
the
20240910-configure-enable-all-asm-and-sp-cleanup
branch
from
ebd2855
to
3fac3b7
Compare
…ng var, by refactoring gating for WOLFSSL_OCSP_PARSE_STATUS sections for clarity.
kaleb-himes
approved these changes
Sep 12, 2024
SparkiDev
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure.ac:--enable-all-asm(enablessp-asmand eitherintelasmorarmasm), and add it to--enable-all-crypto.--enable-all-asmin--enable-all-cryptoenable-all-cryptosettings in one place (--enable-allnow simply activates--enable-all-crypto).enable-allandenable-all-cryptosetup, correctly conditionalize several FIPS-v6-only features/algorithms.wolfcrypt/src/siphash.c: fixes forbugprone-macro-parentheses.wolfcrypt/src/sp_int.c: fixbugprone-too-small-loop-variablein_sp_mul().SP asm: fixes for several
bugprone-macro-parenthesesand-Wconversions.tested with
wolfssl-multi-test.sh ... super-quick-check quantum-safe-wolfssl-all-cppcheck clang-tidy-all-sp-all quantum-safe-wolfssl-all-clang-tidy quantum-safe-wolfssl-all-no-asm-clang-tidy quantum-safe-wolfssl-all-cross-aarch64-armasm-unittest-sanitizer quantum-safe-wolfssl-all-cross-armv7a-armasm-unittestwith--enable-all[-crypto]updated to enable sp-asm and intelasm/armasm on full Gnu C targets.review+merge with https://github.com/wolfSSL/scripts/pull/423