Testing and Review

[NickGreen]

Checklist for testing:

• Cache is created correctly on plugin activation
• Cache is deleted on plugin deactivation
• Cache is updated correctly when subscription statuses change
• Cache is updated correctly when subscription is purchased
• Unrestricted subscription products can be purchased normally
• Simple subscription is not visible in shop and not purchasable, when restricted
• Variable subscription is not visible in shop and variations are not purchasable, when product is restricted
• Not allowing multiple quantities from making it through the cart if it bumps above the restricted number
• Place product in cart/checkout, then restrict it and try to checkout
• Manual Renewal should still work for a restricted product
• Paying for a failed renewal order should still work for a restricted product
• Switching between grouped simple products should prevent purchase if the one being switched to is restricted
• Switching between variations of a variable product should bypass the restriction, since restriction is set on a product level
• Resubscription should not work if the product became restricted since the sub was cancelled or expired
• Restriction can be set sitewide in Subs settings and also from product page
• Product-level restriction setting will override storewide setting

[NickGreen]

Testing checklist 2018-02-06

• Cache is created correctly on plugin activation
• Cache is deleted on plugin deactivation
• Cache is updated correctly when subscription statuses change
• Cache is updated correctly when subscription is purchased
• Unrestricted subscription products can be purchased normally
• Simple subscription is not visible in shop and not purchasable, when restricted
• Variable subscription is not visible in shop and variations are not purchasable, when product is restricted
• Not allowing multiple quantities from making it through the cart if it bumps above the restricted number
• Place product in cart/checkout, then restrict it and try to checkout
• Manual Renewal should still work for a restricted product
• Paying for a failed renewal order should still work for a restricted product
• Switching between grouped simple products should prevent purchase if the one being switched to is restricted
• Switching between variations of a variable product should bypass the restriction, since restriction is set on a product level
• Resubscription should not work if the product became restricted since the sub was cancelled or expired

[NickGreen]

From Bernat's testing:

• When switching between variations, going back to the same product page allows you to purchase more of that same variation.
• Verify that unable to switch to the same variation, after adding new variation to cart.
• Switching might not be updating the cache.
• Filter "not purchasable" message to explain that it's restricted.

[NickGreen]

@bernattorras I've got quantity validation running now, and I think it works 😆

Would you be able to test the latest version and see if it works for you as well?

[NickGreen]

@james-allan I think this is ready for us to put together a plan for reviewing the code. I have probably 5-10 customers that I've seen request this functionality in the last couple of months, and I'd love to get it in good enough shape to have them start using it.

A couple of concerns I have:

• Coding Standards: the PHP is highly likely to not be up to snuff in terms of Prospress standards. Any pointers in terms of having a clean structure and/or following standards is very much appreciated.

• Function Nesting: some of the functions get run multiple times when viewing a product page. For example, the renewal function checks if it's a renewal and the basic restriction runs also. There may be some room for increasing performance by making sure functions don't run twice. But then again, it's maybe not important at this stage.

• Rolling out to customers: what's our standard for releasing to customers? Should we run it through a review, then release to one store first? Any thoughts on that?

[JPry]

@james-allan @NickGreen

Coding Standards

I'd be glad to volunteer to go through the codebase with Nick and do cleanup and review.

Aside from that, Nick can get a good start by reviewing the WordPress PHP Standards and Documentation Standards. These will help you see what standards we follow for WordPress, and you can probably see some things in the code yourself that you'll want to update.