-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporting the packageResolve
function
#18
Comments
Yo Pierre! Now that So perhaps pushing for nodejs/node#49445 I think might be better? Anyway, feel free to PR this for now. |
Thank you for your swift response, and for pointing me to nodejs/node#49445! After reading the whole thread this morning, I added missing tests on my library and started a little refactoring: it turns out Thank you for your guidance 😄 |
Hey there 👋 Thanks for developing this great package!
I am working on an ESM version of
import-from
(ingeniously namedimport-from-esm
), for which I needed to emulaterequire
's behavior using ESM dynamicimport
.I found a function (
packageResolve
) in your library that saved me 99% of the work, and by using it I don't have to implementnode_modules
tree traversal, export maps resolution, etc...Because that function isn't exported by your package, I have copied the sources (and license) from
import-meta-resolve/lib/
, exported thepackageResolve
function, removed theresolve
&moduleResolve
functions, and pruned unused code.As discussed on semantic-release/release-notes-generator#544 (comment), it would be best to directly use your library for updates and security concerns, if you'd agree to export the
packageResolve
function (without necessarily documenting it).Please let me know if you'd be okay with that, or if there are any concerns on your mind!
The text was updated successfully, but these errors were encountered: