Address detekt issues

wordpress-mobile · Jun 15, 2024 · 82c48d6 · 82c48d6
1 parent b22898c
commit 82c48d6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.kt b/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.kt
@@ -3534,18 +3534,13 @@ class EditPostActivity : LocaleAwareActivity(), EditorFragmentActivity, EditorIm
     }
 
     private fun updateVoiceContentIfNeeded() {
-        // Set the voiceToContent content if it exits and this is a GB Editor fragment - do this only once
-        val hasVoiceContent = intent.hasExtra(EditPostActivityConstants.EXTRA_VOICE_CONTENT)
-        if (isNewPost && hasVoiceContent && !isVoiceContentSet) {
-            editorFragment?.let {
-                if (it is GutenbergEditorFragment) {
-                    val gutenbergFragment = editorFragment as GutenbergEditorFragment
-                    val content = intent.getStringExtra(EditPostActivityConstants.EXTRA_VOICE_CONTENT)
-                    content?.let {
-                        isVoiceContentSet = true
-                        gutenbergFragment.updateContent(content)
-                    }
-                }
+        // Check if voice content exists and this is a new post for a Gutenberg editor fragment
+        val content = intent.getStringExtra(EditPostActivityConstants.EXTRA_VOICE_CONTENT)
+        if (isNewPost && content != null && !isVoiceContentSet) {
+            val gutenbergFragment = editorFragment as? GutenbergEditorFragment
+            gutenbergFragment?.let {
+                isVoiceContentSet = true
+                it.updateContent(content)
             }
         }
     }

diff --git a/...ess/src/main/java/org/wordpress/android/ui/voicetocontent/VoiceToContentDialogFragment.kt b/...ess/src/main/java/org/wordpress/android/ui/voicetocontent/VoiceToContentDialogFragment.kt
@@ -83,6 +83,7 @@ class VoiceToContentDialogFragment : BottomSheetDialogFragment() {
                 }
 
                 override fun onSlide(bottomSheet: View, slideOffset: Float) {
+                    // no op
                 }
             })
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                     override fun onSlide(bottomSheet: View, slideOffset: Float) {
+                        // no op
                     }
                 })
@@ Expand Down @@