From fb445cc1fccd8d81475a69885c42973d31767411 Mon Sep 17 00:00:00 2001 From: Neel Doshi Date: Tue, 11 Jun 2024 17:26:06 +0530 Subject: [PATCH] Update PostSettingsInputDialogFragment.java --- .../ui/posts/PostSettingsInputDialogFragment.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostSettingsInputDialogFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostSettingsInputDialogFragment.java index ad082d278e91..981a32338872 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/posts/PostSettingsInputDialogFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/posts/PostSettingsInputDialogFragment.java @@ -20,7 +20,6 @@ import org.wordpress.android.databinding.PostSettingsInputDialogBinding; import org.wordpress.android.util.ActivityUtils; -import java.util.Objects; public class PostSettingsInputDialogFragment extends DialogFragment implements TextWatcher { public static final String TAG = "post_settings_input_dialog_fragment"; @@ -35,7 +34,6 @@ public interface PostSettingsInputDialogListener { private static final String DISABLE_EMPTY_INPUT_TAG = "disable_empty_input"; private static final String MULTILINE_INPUT_TAG = "is_multiline_input"; - private PostSettingsInputDialogBinding mBinding; private String mCurrentInput; private String mTitle; private String mHint; @@ -97,7 +95,8 @@ public Dialog onCreateDialog(Bundle savedInstanceState) { new MaterialAlertDialogBuilder(new ContextThemeWrapper(getActivity(), R.style.PostSettingsTheme)); LayoutInflater layoutInflater = requireActivity().getLayoutInflater(); //noinspection InflateParams - mBinding = PostSettingsInputDialogBinding.inflate(layoutInflater, null, false); + PostSettingsInputDialogBinding mBinding = + PostSettingsInputDialogBinding.inflate(layoutInflater, null, false); builder.setView(mBinding.getRoot()); if (mIsMultilineInput) { mBinding.postSettingsInputDialogEditText.setRawInputType(InputType.TYPE_TEXT_FLAG_MULTI_LINE); @@ -119,7 +118,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) { builder.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { - mCurrentInput = Objects.requireNonNull(mBinding.postSettingsInputDialogEditText.getText()).toString(); + mCurrentInput = mBinding.postSettingsInputDialogEditText.getText().toString(); if (mListener != null) { mListener.onInputUpdated(mCurrentInput); } @@ -152,10 +151,4 @@ public void afterTextChanged(Editable editable) { mDialog.getButton(Dialog.BUTTON_POSITIVE).setEnabled(!disabled); } } - - @Override - public void onDestroy() { - super.onDestroy(); - mBinding = null; // ensures binding reference gets null on fragment destroy - } }