Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No message shown when SMS rate limiting applies #16035

Open
guarani opened this issue Mar 2, 2022 · 1 comment
Open

No message shown when SMS rate limiting applies #16035

guarani opened this issue Mar 2, 2022 · 1 comment

Comments

@guarani
Copy link
Contributor

guarani commented Mar 2, 2022

Expected behavior

When logging in via SMS-based two-factor authentication (2FA), the app should display a message to the user if it unable to send the SMS code (e.g. due to rate-limiting of one message per minute).

Actual behavior

When the app is unable to send an SMS code, it doesn't notify the user. Instead, the message simply doesn't arrive and this leads to potential user confusion.

Steps to reproduce the behavior

  1. Locate a WP.com account with SMS-based 2FA
  2. The following steps should be done in quick succession (within 60 seconds):
    a. Perform an action that requires an SMS code to be used (e.g. change the account password on WordPress.com via the browser)
    b. Log in to the WPAndroid app and notice the app indicates that a message has been sent
  3. Notice that no SMS is received
  4. (Optional) Wait till 60 seconds after Step 2a was performed and try again: notice that the SMS arrives correctly

Desired solution

It would be nice to show a message similar to WP.com, which displays "SMS codes are limited to once per minute. Please wait and try again". This was discussed in #15961 (comment).

Screen Shot 2022-03-02 at 17 14 06

Tested on Samsung S10, Android 11, WPAndroid 19.2
@guarani
Copy link
Contributor Author

guarani commented Aug 14, 2023

I ran into this review of the 22.9 beta and it could be related, but it's not clear yet what the problem is:

authenticator not recognize, text code not responding ,cant login please fix

The "text code not responding" sounds like it could be the SMS not arriving, which matches this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants