Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary logs from the domain screen in the site creation flow #19440

Merged
merged 1 commit into from
May 30, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Oct 24, 2023

This removes unnecessary and too-long logs from the domain list screen in the site creation flow. This log only appears on debug builds.

To test:

  1. Launch the JP app.
  2. Ensure "Me → App Settings → Privacy settings → Collect information" is enabled.
  3. Enable the plans_in_site_creation flag from "Me → Debug settings".
  4. Navigate to My Site.
  5. Tap on the arrow at the end of the site name to open the site list.
  6. Tap on the + button and "Create WordPress.com site".
  7. Skip topic and theme selection screens.
  8. Navigate back to the "Me → Help → Logs"
  9. Verify that there is no log starting with "DOMAIN_REGISTRATION" in recorded logs.

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Nothing.

  3. What automated tests I added (or what prevented me from doing so)
    Nothing since this only removed a debug log.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19440-a21ddae
Commita21ddae
Direct Downloadjetpack-prototype-build-pr19440-a21ddae.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19440-a21ddae
Commita21ddae
Direct Downloadwordpress-prototype-build-pr19440-a21ddae.apk
Note: Google Login is not supported on these builds.

@irfano irfano modified the milestones: 23.6, 23.7 Oct 28, 2023
@irfano irfano modified the milestones: 23.7, 23.8 Nov 13, 2023
@irfano irfano modified the milestones: 23.8, 23.9 Nov 25, 2023
@irfano irfano modified the milestones: 23.9, 24.0 Dec 11, 2023
@irfano irfano removed this from the 24.0 milestone Jan 7, 2024
@guarani
Copy link
Contributor

guarani commented May 30, 2024

@notandyvee @aditi-bhatia @ravishanker would any of you be able to review this please?

I forgot about it for a while and now @irfano reminded me of it, but it's probably best left for an Android developer.

@ravishanker ravishanker self-requested a review May 30, 2024 23:13
Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker added this to the 25.1 milestone May 30, 2024
@ravishanker ravishanker merged commit 92830fa into trunk May 30, 2024
3 checks passed
@ravishanker ravishanker deleted the remove-unnecessary-logs-from-domain-list-sreen branch May 30, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants