Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Use Body Small style for Announcement card descriptions #20883

Merged
merged 1 commit into from
May 27, 2024

Conversation

thomashorta
Copy link
Contributor

It uses 12sp instead of the 11sp used by the footnote style, making it more readable.

Before After
20621-reader-announcement-current-font 20621-reader-announcement-12sp-description

To Test:

Make sure the reader announcement was not previously dismissed.

  1. Open Jetpack
  2. Go to Reader
  3. Verify the description font size is bigger (12sp) than it was before (11sp)

Regression Notes

  1. Potential unintended areas of impact

    • NA
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • NA
  3. What automated tests I added (or what prevented me from doing so)

    • NA

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

It uses 12sp instead of the 11sp used by the footnote style, making it more
readable.
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.0. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20883-fae1ff3
Commitfae1ff3
Direct Downloadjetpack-prototype-build-pr20883-fae1ff3.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20883-fae1ff3
Commitfae1ff3
Direct Downloadwordpress-prototype-build-pr20883-fae1ff3.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and reads better to me! 👍

@thomashorta thomashorta merged commit d8a3dd3 into trunk May 27, 2024
21 of 24 checks passed
@thomashorta thomashorta deleted the fix/reader-announcement-font-size branch May 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants