Update dependency fastlane-plugin-wpmreleasetoolkit to v11 #20922
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Generated by 🚫 Danger |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20922-a378a5e | |
| Commit | a378a5e | |
| Direct Download | wordpress-prototype-build-pr20922-a378a5e.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20922-a378a5e | |
| Commit | a378a5e | |
| Direct Download | jetpack-prototype-build-pr20922-a378a5e.apk |
wzieba
added
the
bot: dependencies update
|
@iangmaia @AliSoftware - is it safe to merge? I'd like to double-check with you, as this is a bump of 2 major. |
There was a problem hiding this comment.
This major bump can't be merged without changes to the fastlane files (see inline comment + migration guide)
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 9.2' | ||
| gem 'fastlane-plugin-wpmreleasetoolkit', '~> 11.0' |
There was a problem hiding this comment.
See https://github.com/wordpress-mobile/release-toolkit/blob/trunk/MIGRATION.md
- Project uses ruby version
3.2.2➡️ yes -
setbranchprotectionrenamed toset_branch_protection, withcopy_branch_protection(from:…)being usually even a better replacement for it ➡️ ❌ Used infastlane/lanes/release.rb:79 -
removebranchprotectionrenamedremove_branch_protection➡️ ❌ Used infastlane/lanes/release.rb:296 -
setfrozentagrenamedset_milestone_frozen_marker➡️ ❌ Used infastlane/lanes/release.rb:80and infastlane/lanes/release.rb:318 -
ios_clear_intermediate_tagsandios_final_tagactions removed -
has_alpha_versionremoved ➡️ ✅ Not used -
project_nameandproject_root_folderremoved ➡️ ✅ Not used -
update_pull_requests_milestonerenamed toupdate_assigned_milestone(+ parameters renamed) ➡️ ✅ Not used -
ios_check_beta_depsparameter updated
There was a problem hiding this comment.
I've updated the calls to be in line with the release-toolkit version 11.0.2 (cc @wzieba)
iangmaia
force-pushed
the
renovate/fastlane-plugin-wpmreleasetoolkit-11.x
branch
from
479189c to
d20a7bf
Compare
fastlane/lanes/release.rb
Outdated
| @@ -76,8 +76,8 @@ | |||
|
|
|||
| push_to_git_remote(tags: false) | |||
|
|
|||
| setbranchprotection(repository: GHHELPER_REPO, branch: "release/#{new_version}") | |||
| setfrozentag(repository: GHHELPER_REPO, milestone: new_version) | |||
| set_branch_protection(repository: GHHELPER_REPO, branch: "release/#{new_version}") | |||
There was a problem hiding this comment.
Shouldn't we start using copy_branch_protection(from: DEFAULT_BRANCH, to: "release/…") instead?
There was a problem hiding this comment.
At first I thought it would be ok to keep as set, but I realize now apps seem to use copy_branch_protection; also, it will just follow whatever we have in trunk, which might be different per repo so it seems more consistent. Changed on a378a5e.
|
This PR contains the following updates:
'~> 9.2'->'~> 11.0'Release Notes
wordpress-mobile/release-toolkit (fastlane-plugin-wpmreleasetoolkit)
v11.0.1Compare Source
Bug Fixes
android_download_translationsaction by correctly calling Fastlane'sgit_submodule_updateaction [#561]v11.0.0Compare Source
Breaking Changes
ios_check_beta_depsuse thePodfile.lockinstead ofPodfilefor its detection, and also be able to detect Pods referenced by commits and branches.If your
Fastfilecalled this action with an explicitpodfile: …argument, you'll have to update the call to uselockfile:instead (or rely on defaults). [#557]v10.0.0Compare Source
Breaking Changes
3.2.2. [#517]setbranchprotectionandremovebranchprotectionbackwards-compatiblity stubs for the now-renamedset_branch_protectionandremove_branch_protectionactions. [#549]setfrozentagaction toset_milestone_frozen_marker. [#548]ios_clear_intermediate_tagsaction, which has been deprecated for a while. [#549]has_alpha_versionoption from several actions and helper methods. It has already been deprecated for many versions. [#550]project_nameandproject_root_folderoptions from several actions. [#550]update_pull_requests_milestonetoupdate_assigned_milestoneand make it handle GitHub issues as well as PRs. [#547]Bug Fixes
comment_on_prto allow first paragraph of the comment to still be interpreted as Markdown. [#544]Internal Changes
GitHelper.ensure_on_branch!method [#531]GitHelper.update_submodulesmethod [#531]nokogiri,mini_portile2, andrmagick[#546]Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.