Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Show custom lists directly if there are 2 or fewer items #20940

Conversation

RenanLukas
Copy link
Contributor

Fixes #20033


To Test:

  • Make sure you have more than 2 custom reading lists (you can see your lists here).
  • Install JP and sign in.
  • Open Reader.
  • 🔍 Expand the dropdown menu: you should see the "Lists" submenu item, and when tapping on it you should see the names of your lists.
Screenshot 2024-06-05 at 1 34 29 PM
  • Make sure you have 2 or less custom reading lists.
  • Reload the Reader.
  • 🔍 Expand the dropdown menu: instead of seeing the "Lists" submenu, you should see the custom lists items directly in the main menu.
Screenshot 2024-06-05 at 1 33 33 PM -----

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing and updated unit tests
  3. What automated tests I added (or what prevented me from doing so)

    • Updated ReaderTopBarMenuHelperTest.kt

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@RenanLukas RenanLukas marked this pull request as ready for review June 5, 2024 18:19
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20940-03b73d8
Commit03b73d8
Direct Downloadjetpack-prototype-build-pr20940-03b73d8.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20940-03b73d8
Commit03b73d8
Direct Downloadwordpress-prototype-build-pr20940-03b73d8.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.94%. Comparing base (a24e5d1) to head (03b73d8).

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20940   +/-   ##
=======================================
  Coverage   40.93%   40.94%           
=======================================
  Files        1519     1519           
  Lines       69554    69562    +8     
  Branches    11473    11474    +1     
=======================================
+ Hits        28473    28481    +8     
  Misses      38495    38495           
  Partials     2586     2586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thomashorta thomashorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM! :shipit:

@RenanLukas RenanLukas merged commit fe8a023 into trunk Jun 5, 2024
22 checks passed
@RenanLukas RenanLukas deleted the issue/20033-show-lists-directly-dropdown-menu-if-2-or-fewer-items branch June 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reader IA] Show lists directly on dropdown menu if there are 2 or fewer
4 participants