Comment details menu redesign #20944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20944-78a2b09 | |
| Commit | 78a2b09 | |
| Direct Download | wordpress-prototype-build-pr20944-78a2b09.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20944-78a2b09 | |
| Commit | 78a2b09 | |
| Direct Download | jetpack-prototype-build-pr20944-78a2b09.apk |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/notifications_refresh_p2 #20944 +/- ##
=================================================================
Coverage 40.98% 40.98%
=================================================================
Files 1523 1523
Lines 69626 69626
Branches 11513 11515 +2
=================================================================
Hits 28534 28534
Misses 38504 38504
Partials 2588 2588 ☔ View full report in Codecov by Sentry. |
jarvislin
commented
Jun 7, 2024
| @@ -195,7 +195,9 @@ class NotificationsDetailListFragment : ListFragment(), NotificationFragment { | |||
| this.footerView = footerView | |||
| } | |||
|
|
|||
| private val mOnNoteBlockTextClickListener = NoteBlockTextClickListener(this, notification, onActionClickListener) | |||
| private val mOnNoteBlockTextClickListener by lazy { | |||
There was a problem hiding this comment.
onActionClickListener is always null if we don't use by lazy because we create mOnNoteBlockTextClickListener when onActionClickListener has not been set value.
antonis
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Awesome work @jarvislin 🏅
The code looks good and the app performed as described in my tests 🎉
antonis
merged commit 5493500
into
feature/notifications_refresh_p2
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/Automattic/wordpress-mobile/issues/44
This PR contains the implementations of the
Shareaction andChange Statusaction in the comment menu.To Test:
...SharebuttonChange statusbuttonRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
skipped
Testing Checklist (strike-out the not-applying and unnecessary ones):
skipped