Fix NPE in EditPostActivty onPostUploaded #20954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20953
This PR addresses a potential NullPointerException in the
onPostUploaded
event handler by ensuring that theeditPostRepository.id
is safely accessed. InEditPostActivity
, the EventBus is registered beforeEditPostRepository
is fully initialized. As such, there is a risk that an onPostUploaded event might be posted before the EditPostRepository has completed its initialization process, thus causing an NPE when "id" is accessed.Changes:
This ensures that the check post.id == editPostId will fail if editPostRepository.getPost() returns null, preventing a NullPointerException.
To Test:
As I was unable to recreate the issue, please validate that the Create/Edit post flow works as expected.
Regression Notes
Potential unintended areas of impact
The crash still occurs
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): N/A