Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revert] This reverts adding foregroundServiceType to many services. #20978

Merged
merged 2 commits into from
Jun 13, 2024
Merged

[Revert] This reverts adding foregroundServiceType to many services. #20978

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491e138
Revert "Merge pull request #19981 from wordpress-mobile/fix/target-sd…
notandyvee Jun 10, 2024
69efddc
Merge branch 'trunk' into andy/revert-foreground-service-types
notandyvee Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 19 additions & 38 deletions WordPress/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,105 +844,88 @@
<service
android:name=".ui.reader.services.update.ReaderUpdateService"
android:exported="false"
android:label="Reader Update Service"
android:foregroundServiceType="dataSync"/>
android:label="Reader Update Service" />
<service
android:name=".ui.reader.services.update.ReaderUpdateJobService"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="false"
android:label="Reader Update JobService"
android:foregroundServiceType="dataSync"/>
android:label="Reader Update JobService" />

<service
android:name=".ui.reader.services.discover.ReaderDiscoverService"
android:exported="false"
android:label="Reader Discover Service"
android:foregroundServiceType="dataSync"/>
android:label="Reader Discover Service" />
<service
android:name=".ui.reader.services.discover.ReaderDiscoverJobService"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="false"
android:label="Reader Discover JobService"
android:foregroundServiceType="dataSync"/>
android:label="Reader Discover JobService" />

<service
android:name=".ui.reader.services.post.ReaderPostService"
android:exported="false"
android:label="Reader Post Service"
android:foregroundServiceType="dataSync"/>
android:label="Reader Post Service" />
<service
android:name=".ui.reader.services.post.ReaderPostJobService"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="false"
android:label="Reader Post JobService"
android:foregroundServiceType="dataSync"/>
android:label="Reader Post JobService" />

<service
android:name=".ui.reader.services.search.ReaderSearchService"
android:exported="false"
android:label="Reader Search Service"
android:foregroundServiceType="dataSync"/>
android:label="Reader Search Service" />
<service
android:name=".ui.reader.services.search.ReaderSearchJobService"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="false"
android:label="Reader Search Job Service"
android:foregroundServiceType="dataSync"/>
android:label="Reader Search Job Service" />

<service
android:name=".ui.reader.services.comment.ReaderCommentService"
android:exported="false"
android:label="Reader Comment Service"
android:foregroundServiceType="dataSync"/>
android:label="Reader Comment Service" />

<service
android:name=".ui.suggestion.service.SuggestionService"
android:exported="false"
android:label="Suggestion Service"
android:foregroundServiceType="dataSync"/>
android:label="Suggestion Service" />
<service
android:name=".push.NotificationsProcessingService"
android:exported="false"
android:label="Notifications Quick Actions processing Service"
android:foregroundServiceType="dataSync"/>
android:label="Notifications Quick Actions processing Service" />

<service
android:name=".ui.notifications.services.NotificationsUpdateService"
android:exported="false"
android:label="Notifications Update Service"
android:foregroundServiceType="dataSync"/>
android:label="Notifications Update Service" />
<service
android:name=".ui.notifications.services.NotificationsUpdateJobService"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="false"
android:label="Notifications Update Job Service"
android:foregroundServiceType="dataSync"/>
android:label="Notifications Update Job Service" />

<service
android:name=".util.analytics.service.InstallationReferrerService"
android:exported="true"
android:permission="com.google.android.finsky.permission.BIND_GET_INSTALL_REFERRER_SERVICE"
android:label="Installation Referrer Service"
android:foregroundServiceType="dataSync"/>
android:label="Installation Referrer Service" />

<service
android:name=".util.analytics.service.InstallationReferrerJobService"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="false"
android:label="Installation Referrer Service"
android:foregroundServiceType="dataSync"/>
android:label="Installation Referrer Service" />

<service
android:name=".login.LoginWpcomService"
android:exported="false"
android:label="Login to WPCOM Service"
android:foregroundServiceType="dataSync"/>
android:label="Login to WPCOM Service" />

<service
android:name=".ui.sitecreation.services.SiteCreationService"
android:exported="false"
android:label="Site Creation Service"
android:foregroundServiceType="dataSync"/>
android:label="Site Creation Service" />

<!-- Samsung multiwindow support -->
<uses-library
Expand Down Expand Up @@ -1016,8 +999,7 @@
<receiver android:name=".ui.notifications.DismissNotificationReceiver" />
<service
android:name=".ui.stats.refresh.lists.widget.WidgetService"
android:permission="android.permission.BIND_REMOTEVIEWS"
android:foregroundServiceType="dataSync"/>
android:permission="android.permission.BIND_REMOTEVIEWS" />

<activity
android:name=".ui.stats.refresh.lists.widget.views.StatsViewsWidgetConfigureActivity"
Expand Down Expand Up @@ -1077,8 +1059,7 @@

<service
android:name=".push.GCMMessageService"
android:exported="false"
android:foregroundServiceType="dataSync">
android:exported="false" >
<intent-filter>
<action android:name="com.google.firebase.MESSAGING_EVENT" />
</intent-filter>
Expand Down
Loading