Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade targetSdk from 33 to 34. #21003

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Upgrade targetSdk from 33 to 34. #21003

merged 1 commit into from
Jun 19, 2024

Conversation

notandyvee
Copy link
Contributor

Fixes #19917

This PR updates the targetSdk from 33 to 34.


To Test:

  • Uploading images through gutenberg
  • Uploading images through wordpress media
  • Delete media from wordpress.com media.
  • Make a post and edit a post.
  • Use the reader.
  • Comment on a post.
  • Like a post.
  • Notifications should work.
  • Create a site.
  • Test widgets.

Regression Notes

  1. Potential unintended areas of impact

    There should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Manual tests

  3. What automated tests I added (or what prevented me from doing so)

    N/A


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@notandyvee notandyvee added this to the 25.2 milestone Jun 18, 2024
@notandyvee notandyvee requested review from irfano and ParaskP7 June 18, 2024 21:35
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21003-fb550c3
Commitfb550c3
Direct Downloadjetpack-prototype-build-pr21003-fb550c3.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21003-fb550c3
Commitfb550c3
Direct Downloadwordpress-prototype-build-pr21003-fb550c3.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 🤞🏻
LGTM!

@irfano irfano merged commit c019439 into trunk Jun 19, 2024
22 checks passed
@irfano irfano deleted the andy/target-sdk-34-take-two branch June 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Wordpress-Android Target SDK to 34
4 participants