Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crashes in UploadUtilsWrapper caused by null snackbarAttachView #21012

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Jun 21, 2024

Fixes #21010
I can't reproduce the crash, but it occurs when the activity is stopped while the snackbar is being invoked in a separate thread, such as in onActivityResult or EventBus functions. Therefore, I added a check before showing snackbars.

There are different crashes on Sentry related to UploadUtilsWrapper. If the snackbarAttachView is null, it's pointless to call functions showing snackbars. I made all snackbarAttachView parameters non-null and checked their nullability in the Java classes where these UploadUtilsWrapper' functions are being called.


To Test:

Since I can't reproduce it, it's not testable.


Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Since I can't reproduce it, I didn't add a test.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 21, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.2. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Jun 21, 2024

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21012-59a69e6
Commit59a69e6
Direct Downloadjetpack-prototype-build-pr21012-59a69e6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21012-59a69e6
Commit59a69e6
Direct Downloadwordpress-prototype-build-pr21012-59a69e6.apk
Note: Google Login is not supported on these builds.

@oguzkocer oguzkocer merged commit 3528bf5 into release/25.1 Jun 21, 2024
22 of 23 checks passed
@oguzkocer oguzkocer deleted the issue/21010-fix-crash-on-showing-snackbars branch June 21, 2024 19:34
Copy link

sentry-io bot commented Jun 24, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.analytics.AnalyticsTracke... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants