Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert targetSdk to 33 #21033

Closed
wants to merge 1 commit into from
Closed

Revert targetSdk to 33 #21033

wants to merge 1 commit into from

Conversation

irfano
Copy link
Member

@irfano irfano commented Jul 5, 2024

This reverts the targetSdk to 33. Because we found two more services (SiteCreationService and LoginWpcomService) that extends AutoForeground and calls startForeground(). Since they call startForeground() these services are also foreground services and they need foregroundServiceType. Currently, we set service type only for UploadService and MediaDeleteService.

Further discussion: pcdRpT-5fy-p2#comment-10425


To Test:

No need to test. This PR reverts targetSdk to the version that is currently used in the store version.


Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • I didn't add any test since this only revert the targetSdk.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano added this to the 25.3 milestone Jul 5, 2024
@irfano irfano requested review from notandyvee and oguzkocer July 5, 2024 16:38
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.3. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Jul 5, 2024

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21033-5d4f38e
Commit5d4f38e
Direct Downloadwordpress-prototype-build-pr21033-5d4f38e.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21033-5d4f38e
Commit5d4f38e
Direct Downloadjetpack-prototype-build-pr21033-5d4f38e.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@notandyvee notandyvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean revert. Thanks for this @irfano 🙏🏻

@nbradbury
Copy link
Contributor

Just a note that when we do tackle the update to Android 14, on Upside Down Cake and above we need to call ServiceCompat.startService with a foreground service type. From a quick glance at our code, we may only need to be concerned about that for UploadService.

@irfano
Copy link
Member Author

irfano commented Jul 10, 2024

@nbradbury, we can use ServiceCompat only if we pass the foreground service type in the startService() call.

If the foreground service type is not specified in the call, the type defaults to the values defined in the manifest.
- https://developer.android.com/about/versions/14/changes/fgs-types-required#include-fgs-type-runtime

I think we don't need to pass the foreground service type in the startService() call since they're already defined in the AndroidManifest.

@nbradbury
Copy link
Contributor

We can probably hold off merging this since #21059 addresses the missing services and other Android 14 requirements.

@oguzkocer
Copy link
Contributor

This was directly reverted in release/25.2.

@oguzkocer oguzkocer closed this Jul 23, 2024
@oguzkocer oguzkocer deleted the revert-targetsdk-to-33 branch July 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants