-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert targetSdk to 33 #21033
Revert targetSdk to 33 #21033
Conversation
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean revert. Thanks for this @irfano 🙏🏻
Just a note that when we do tackle the update to Android 14, on Upside Down Cake and above we need to call |
@nbradbury, we can use
I think we don't need to pass the foreground service type in the |
We can probably hold off merging this since #21059 addresses the missing services and other Android 14 requirements. |
This was directly reverted in |
This reverts the
targetSdk
to 33. Because we found two more services (SiteCreationService
and LoginWpcomService) that extendsAutoForeground
and callsstartForeground()
. Since they callstartForeground()
these services are also foreground services and they needforegroundServiceType
. Currently, we set service type only for UploadService and MediaDeleteService.Further discussion: pcdRpT-5fy-p2#comment-10425
To Test:
No need to test. This PR reverts targetSdk to the version that is currently used in the store version.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
WordPress.com sites and self-hosted Jetpack sites.Portrait and landscape orientations.Light and dark modes.Fonts: Larger, smaller and bold text.High contrast.Talkback.Languages with large words or with letters/accents not frequently used in English.Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)Large and small screen sizes. (Tablet and smaller phones)Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)