Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Highlight text bug fixes #22425

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jan 19, 2024

Related PRs:

Fixes several issues related to the Highlight text formatting in the Gutenberg editor.


To Test:

Please check the testing instructions in the Gutenberg PR description.


Regression Notes

  1. Potential unintended areas of impact

    • It should only affect the editor.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing, and integration tests in both Aztec and Gutenberg.
  3. What automated tests I added (or what prevented me from doing so)

    • Visual E2E tests added in Gutenberg Mobile.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 19, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22425-0b97ec3
Version24.5
Bundle IDorg.wordpress.alpha
Commit0b97ec3
App Center BuildWPiOS - One-Offs #9229
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 19, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22425-0b97ec3
Version24.5
Bundle IDcom.jetpack.alpha
Commit0b97ec3
App Center Buildjetpack-installable-builds #8274
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux geriux added this to the 24.2 milestone Jan 24, 2024
@geriux geriux marked this pull request as ready for review January 24, 2024 11:09
@geriux geriux modified the milestones: 24.2, 24.3 Feb 1, 2024
@mokagio
Copy link
Contributor

mokagio commented Feb 19, 2024

I'm going to bump this to the next release because we'll be code freezing 24.3 today and it seems like this has not been approved yet.

For the record, I also checked the Gutenberg PR in the hope that it was already merged and shipped, meaning this PR could be closed as the changes would be fetched as part of the next Gutenberg release, but that was not the case.

@mokagio mokagio modified the milestones: 24.3, 24.4 Feb 19, 2024
@geriux geriux removed this from the 24.4 milestone Feb 20, 2024
@geriux
Copy link
Contributor Author

geriux commented Mar 18, 2024

Hey @twstokes 👋 I was wondering if you'd be able to review this PR if you have some time. It only updates the Aztec and Gutenberg references, although it won't be merged until both Gutenberg Mobile and Aztec have their new tag released with the new changes. Thank you!

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me @geriux! 🚀

@geriux geriux added this to the 24.6 milestone Mar 21, 2024
@geriux geriux force-pushed the gutenberg/fix-highlight-feature branch from 7ada90a to a95c884 Compare March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants