Update Blog.dotComID value if needed before saving

[crazytonyli]

Issue

Blog.blogID could be 0, even though it's a dot com site and we know its site id from its jetpack info. This is an edge case that happens after a non-jetpack site is connected to jetpack.

WordPress-iOS/WordPress/Classes/Models/Blog/Blog.m

Lines 765 to 777 in 629899b

	- (NSNumber *)dotComID
	{
	[self willAccessValueForKey:@"blogID"];
	NSNumber *dotComID = [self primitiveValueForKey:@"blogID"];
	if (dotComID.integerValue == 0) {
	dotComID = self.jetpack.siteID;
	if (dotComID.integerValue > 0) {
	self.dotComID = dotComID;
	}
	}
	[self didAccessValueForKey:@"blogID"];
	return dotComID;
	}

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 25.6. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23884-934da1c
	Version	25.5
	Bundle ID	org.wordpress.alpha
	Commit	934da1c
	App Center Build	WPiOS - One-Offs #11158

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23884-934da1c
	Version	25.5
	Bundle ID	com.jetpack.alpha
	Commit	934da1c
	App Center Build	jetpack-installable-builds #10198

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[kean]

It looks like a good place to do it: "This method can have “side effects” on persistent values. You can use it to, for example, compute persistent values from other transient or scratchpad values." 👍

Having said that, this rename to dotComID has been a real PITA. It's be nice to do a migration and remove the original field. I plan to wrap up this #23788 this week and add more stuff that can be removed form the database. And there are a ton of existing deprecations, especially in Blog.