Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad: Default to the displace mode #23886

Merged
merged 1 commit into from
Dec 12, 2024
Merged

iPad: Default to the displace mode #23886

merged 1 commit into from
Dec 12, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 11, 2024

The app was originally designed to work with the .displace mode. The .tile behavior looks a bit rough and confusing. It turns out, the .automatic behavior switches to .tile quite often depending on the screen size, which we don't want.

Before

Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2024-12-11.at.10.50.34.mp4

After

Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2024-12-11.at.10.53.26.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the iPad label Dec 11, 2024
@kean kean requested a review from crazytonyli December 11, 2024 15:56
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23886-42f04cc
Version25.5
Bundle IDorg.wordpress.alpha
Commit42f04cc
App Center BuildWPiOS - One-Offs #11162
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23886-42f04cc
Version25.5
Bundle IDcom.jetpack.alpha
Commit42f04cc
App Center Buildjetpack-installable-builds #10201
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this pull request to the merge queue Dec 12, 2024
Merged via the queue into trunk with commit d86a3a4 Dec 12, 2024
26 checks passed
@kean kean deleted the fix/displace-behavior branch December 12, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants