Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] WalletConnect popup shows up unprompted #2671

Open
tonyjin opened this issue Sep 20, 2024 · 3 comments
Open

[Bug] WalletConnect popup shows up unprompted #2671

tonyjin opened this issue Sep 20, 2024 · 3 comments
Assignees
Labels
connect v2 Tickets that relate to the full redesign+sdkv2 replacement p1 Important issue

Comments

@tonyjin
Copy link
Contributor

tonyjin commented Sep 20, 2024

Description and context

WalletConnect popup shows up unprompted when WalletConnect is selected as the wallet option for a chain, but before "Connect source wallet" button is clicked.

Steps to reproduce

  1. Load Connect V2 on Portal
  2. Choose source chain/token, select Ethereum
  3. Connect source wallet, select WalletConnect, but do not choose an option or connect via QR
  4. Reload page
  5. Choose source chain/token
  6. Note that WalletConnect popup shows up beneath the source chain/token popup automatically

Note: This does not appear to be consistently reproducible even with the steps above. It seems like if the localstorage propertywormhole-connect:wallet:Ethereum is set to WalletConnect, this will occur.

Experienced behavior

WalletConnect popup appears unexpectedly

Expected behavior

WalletConnect popup should not appear until "Connect source wallet" button is clicked.

Attached screen recording:
https://github.com/user-attachments/assets/0caa2a1e-3e97-4fc1-aac7-b55395335276

@tonyjin tonyjin added p0 Critical issue connect v2 Tickets that relate to the full redesign+sdkv2 replacement p1 Important issue and removed p0 Critical issue labels Sep 20, 2024
@sebastianscatularo sebastianscatularo self-assigned this Sep 20, 2024
@sebastianscatularo
Copy link
Collaborator

should be fixed once #2686 gets merged

@emreboga
Copy link
Collaborator

I can confirm that I don't see the issue after the above PR is merged.
@tonyjin you wanna double-check?

@tonyjin
Copy link
Contributor Author

tonyjin commented Sep 23, 2024

I wasn't able to reliably reproduce the issue originally, but I also could not reproduce it in the development build post-merging of 2686.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect v2 Tickets that relate to the full redesign+sdkv2 replacement p1 Important issue
Projects
None yet
Development

No branches or pull requests

3 participants