Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Cannot resume transaction - USDC, Manual route #2679

Closed
tsadovska opened this issue Sep 20, 2024 · 6 comments
Closed

[QA] Cannot resume transaction - USDC, Manual route #2679

tsadovska opened this issue Sep 20, 2024 · 6 comments
Assignees
Labels
connect v2 Tickets that relate to the full redesign+sdkv2 replacement p0 Critical issue

Comments

@tsadovska
Copy link
Collaborator

Describe the current behavior in detail

Checked on https://portalbridge.com/:

  • Portal Bridge: v0.2.15-191783896a
  • Wormhole Connect: v^1.0.0-beta.1-development

Steps:

  1. Send 0.00008 USDC from BSC (MetaMask) to Ethereum (MetaMask) with Manual route
  2. Resume the transfer

Actual result: Transfer is not found. Loading does not complete.
Expected result: Transaction is successfully resumed.

Notes/ Attachments

Link to Wormholescan.

Uncaught (in promise) Error: when deserializing item 'mintRecipient': chunk is shorter than expected: 1048 < 1060
    at updateOffset (pb-index-Bk8S0RNv.js:276:9987)
    at deserializeLayoutItem (pb-index-Bk8S0RNv.js:276:11825)
    at internalDeserializeLayout (pb-index-Bk8S0RNv.js:276:10219)
    at deserializeLayout (pb-index-Bk8S0RNv.js:276:9683)
    at pb-index-Bk8S0RNv.js:276:145798
    at deserializePayload (pb-index-Bk8S0RNv.js:276:146041)
    at deserialize$1 (pb-index-Bk8S0RNv.js:276:145436)
    at getVaa (pb-index-Bk8S0RNv.js:281:20216)

image

@tsadovska tsadovska added p0 Critical issue connect v2 Tickets that relate to the full redesign+sdkv2 replacement labels Sep 20, 2024
@kev1n-peters kev1n-peters self-assigned this Sep 20, 2024
@kev1n-peters
Copy link
Collaborator

Issue is in the SDK. This is the actual error I'm getting:

Error: scaleAmount({"amount":"80","decimals":8}, 6) would result in altered amount. Use truncateAmount first if you intended to truncate it.
    at Object.scale (http://localhost:5173/node_modules/.vite/deps/@wormhole-foundation_sdk-base.js?v=8ef798bb:3338:9)
    at TokenTransfer.fromIdentifier (http://localhost:5173/@fs/Users/kevin/repos/wormhole-sdk-ts/connect/dist/esm/protocols/tokenBridge/tokenTransfer.js?t=1726857176087:76:37)
    at async TokenTransfer.fromTransaction (http://localhost:5173/@fs/Users/kevin/repos/wormhole-sdk-ts/connect/dist/esm/protocols/tokenBridge/tokenTransfer.js?t=1726857176087:100:20)
    at async TokenTransfer.from (http://localhost:5173/@fs/Users/kevin/repos/wormhole-sdk-ts/connect/dist/esm/protocols/tokenBridge/tokenTransfer.js?t=1726857176087:50:18)
    at async TokenBridgeRoute.resume (http://localhost:5173/@fs/Users/kevin/repos/wormhole-sdk-ts/connect/dist/esm/routes/tokenBridge/manual.js?t=1726857176087:85:22)
    ```

@kev1n-peters
Copy link
Collaborator

This fixes the scaleAmount issue mentioned above: wormhole-foundation/wormhole-sdk-ts#700

@emreboga
Copy link
Collaborator

Hi @tsadovska, I'm blocked to reproduce this issue as the manual route is not showing up at all. The automatic routes also returns an error about the amount being too low (Mayan as asking for 45 USDC the least). Can you reproduce this issue with a different source/dest configuration?

Screenshot 2024-09-23 at 11 52 56 AM

@tsadovska
Copy link
Collaborator Author

tsadovska commented Sep 23, 2024

@emreboga Issue is also reproducible with following scenario:

  1. Select Base network and USDC (0x83...2913) token in "From" section (in my case, MetaMask wallet was auto-connected)
  2. Select Arbitrum network and USDC (0xaf...5831) token in "To" section (in my case, MetaMask wallet was also auto-connected)
  3. Enter the amount 0.0001 and continue the transfer

Cannot resume the transaction: https://wormholescan.io/#/tx/0xb036260eeb31db2e96b5b6786ef63c28e8fb096aa85b4aabd4e20e987141f7e9

Screen.Recording.2024-09-23.at.15.39.44.mov

image

@kev1n-peters
Copy link
Collaborator

@emreboga Issue is also reproducible with following scenario:

  1. Select Base network and USDC (0x83...2913) token in "From" section (in my case, MetaMask wallet was auto-connected)
  2. Select Arbitrum network and USDC (0xaf...5831) token in "To" section (in my case, MetaMask wallet was also auto-connected)
  3. Enter the amount 0.0001 and continue the transfer

Cannot resume the transaction: https://wormholescan.io/#/tx/0xb036260eeb31db2e96b5b6786ef63c28e8fb096aa85b4aabd4e20e987141f7e9

Screen.Recording.2024-09-23.at.15.39.44.mov
image

This is a different scenario (not a bug) where the transfer cannot be resumed until the attestation message has been produced.

@tsadovska
Copy link
Collaborator Author

Issue is not reproducible on wormhole-connect-mainnet.

  1. Scenario: 0.0008 USDC transfer from BSC (MetaMask) to Ethereum (MetaMask)
    Transfer can be successfully resumed: 0x71c7af6995635a7a274bf16c6d02ecd3511b4e7c1fa0db5101f1a5c5a4fc41cc (BSC). Link to Wormholescan.

  2. Scenario: 0.001 USDC transfer from Ethereum (MetaMask) to Solana (Phantom). Transfer can be successfully resumed: 0x120cc5e38a39a59de8401908ca5bd7a45a31bf824b8ff53e0d6d578ba06ed15a (Ethereum). Link to Wormholescan.

Closing the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect v2 Tickets that relate to the full redesign+sdkv2 replacement p0 Critical issue
Projects
None yet
Development

No branches or pull requests

3 participants