Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mayan min amount messages broken/missing #2698

Closed
Wesleyleung opened this issue Sep 23, 2024 · 2 comments
Closed

[Bug] Mayan min amount messages broken/missing #2698

Wesleyleung opened this issue Sep 23, 2024 · 2 comments
Labels
connect v2 Tickets that relate to the full redesign+sdkv2 replacement p1 Important issue

Comments

@Wesleyleung
Copy link
Collaborator

Wesleyleung commented Sep 23, 2024

Description and context

Steps to reproduce

  1. Choose any asset pair that would generate a Mayan route.
  2. Enter a small number
  3. Get a generic "route not found" error message when this should tell you the min amount you need to enter.

Experienced behavior

Compare the differences between Connect vs Mayan's website
Screenshot 2024-09-23 at 2 02 44 PM
Screenshot 2024-09-23 at 2 02 30 PM

Expected behavior

Inform the user the min amount needed to show a valid route.
If at least 1 route is valid and others are invalid (eg. valid regular Mayan, invalid Mayan Swift), show the valid route and also include a grey info message informing the user more routes are available above > x amount.

Solution recommendation

@Wesleyleung Wesleyleung added connect v2 Tickets that relate to the full redesign+sdkv2 replacement p1 Important issue labels Sep 23, 2024
@emreboga
Copy link
Collaborator

@Wesleyleung this is what I'm seeing in the latest development:

Screenshot 2024-09-24 at 1 35 42 PM

Routes that are not available are not shown and we display "More routes available for amounts exceeding ..." message. This change has been with #2608
I'm not sure why we don't see this message in Portal Bridge though. @nikarm22 Any ideas?

@nikarm22
Copy link
Contributor

@emreboga implementation had a bug in #2608 fixed here https://github.com/wormhole-foundation/wormhole-connect/pull/2639/files#diff-b70720c6703c332cc1a63667def94887e91431bd4c3a190f9bd170d516690e6aL448

Once portal updates to newer release will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect v2 Tickets that relate to the full redesign+sdkv2 replacement p1 Important issue
Projects
None yet
Development

No branches or pull requests

3 participants