From e564f10369ce0b512ea0c36b4f0ee48f77290071 Mon Sep 17 00:00:00 2001 From: Bruce Riley Date: Fri, 16 Aug 2024 09:13:48 -0500 Subject: [PATCH] Code review rework --- ethereum/env/.env.snaxchain.testnet | 2 +- node/pkg/governor/mainnet_tokens_test.go | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ethereum/env/.env.snaxchain.testnet b/ethereum/env/.env.snaxchain.testnet index 8071af990e..abf997ced8 100644 --- a/ethereum/env/.env.snaxchain.testnet +++ b/ethereum/env/.env.snaxchain.testnet @@ -17,5 +17,5 @@ BRIDGE_INIT_CHAIN_ID=43 BRIDGE_INIT_GOV_CHAIN_ID=0x1 BRIDGE_INIT_GOV_CONTRACT=0x0000000000000000000000000000000000000000000000000000000000000004 BRIDGE_INIT_FINALITY=1 -# I think this is right. It’s what we use on Optimism, and it exists on Snax. . . +# Snaxchain is an OP Stack chain and therefore has the same WETH address. https://docs.optimism.io/stack/protocol/features/custom-gas-token#what-is-the-wrapped-erc-20-gas-token BRIDGE_INIT_WETH=0x4200000000000000000000000000000000000006 \ No newline at end of file diff --git a/node/pkg/governor/mainnet_tokens_test.go b/node/pkg/governor/mainnet_tokens_test.go index c37e278ef4..4ea21aafe9 100644 --- a/node/pkg/governor/mainnet_tokens_test.go +++ b/node/pkg/governor/mainnet_tokens_test.go @@ -6,7 +6,6 @@ import ( "testing" "github.com/stretchr/testify/assert" - "github.com/stretchr/testify/require" "github.com/wormhole-foundation/wormhole/sdk/vaa" ) @@ -77,9 +76,11 @@ func TestGovernedChainHasGovernedAssets(t *testing.T) { // Make sure we're not ignoring any chains with governed tokens. for _, tokenEntry := range tokenList() { - if _, exists := ignoredChains[vaa.ChainID(tokenEntry.chain)]; exists { - require.Equal(t, "", fmt.Sprintf("Chain %s is in ignoredChains but it has governed tokens", vaa.ChainID(tokenEntry.chain))) - } + t.Run(vaa.ChainID(tokenEntry.chain).String(), func(t *testing.T) { + if _, exists := ignoredChains[vaa.ChainID(tokenEntry.chain)]; exists { + assert.Fail(t, "Chain is in ignoredChains but it has governed tokens") + } + }) } }