Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: unify signing prefixes #4104

Open
evan-gray opened this issue Aug 30, 2024 · 0 comments
Open

node: unify signing prefixes #4104

evan-gray opened this issue Aug 30, 2024 · 0 comments
Labels

Comments

@evan-gray
Copy link
Contributor

evan-gray commented Aug 30, 2024

Description and context

https://github.com/wormhole-foundation/wormhole/blob/main/whitepapers/0009_guardian_key.md defines the use of signing prefixes. However, these prefixes are currently located throughout the codebase. It would be ideal for them to live in one location.

HeartbeatMessagePrefix = []byte("heartbeat|")
SignedObservationRequestPrefix_old = []byte("signed_observation_request|")
SignedObservationRequestPrefix = []byte("signed_observation_request_000000|")
SignedWormchainAddressPrefix = []byte("signed_wormchain_address_00000000|")
)

var heartbeatMessagePrefix = []byte("heartbeat|")
var signedObservationRequestPrefix = []byte("signed_observation_request|")

var governorMessagePrefixConfig = []byte("governor_config_000000000000000000|")
var governorMessagePrefixStatus = []byte("governor_status_000000000000000000|")

var SubmitObservationPrefix = []byte("acct_sub_obsfig_000000000000000000|")
var NttSubmitObservationPrefix = []byte("ntt_acct_sub_obsfig_00000000000000|")

var queryResponsePrefix = []byte("query_response_0000000000000000000|")

Definition of done

The prefixes all live exclusively in the same go sdk file.

@evan-gray evan-gray added the node label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant