-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve iconv-lite warning #101
Comments
Good catch! 👍 It's probably webpack walking the dependency tree and attempting to require |
The try/catch way of doing things is also mentioned in this webpack issue. |
That issue talks a bit about optional externals. I gave this a shot in Wowser's
Perhaps because this happens indirectly, through a dependency of Blizzardry, it can't be resolved using optional externals? |
Blizzardry uses
restructure
to parse binary files into something usable in JS. It appears thatrestructure
, inEncodeStream.js
, attempts to require a module namediconv-lite
:The
require
is wrapped in atry catch
block, which prevents it from breaking in the eventiconv-lite
isn't installed. However, Node still emits a warning message to the console:I'd propose we make iconv-lite a dependency of Blizzardry. This will silence the console spam.
Other Notes
While I don't think we're using
EncodeStream
for anything,iconv-lite
may pose a challenge for in-browser usage. It has a wrapper shim that's compatible withBrowserify
, but I don't expect it'll work out of the box withwebpack
.The text was updated successfully, but these errors were encountered: