Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerating BIG Images Edited by User #136

Open
ddur opened this issue Aug 16, 2020 · 1 comment
Open

Regenerating BIG Images Edited by User #136

ddur opened this issue Aug 16, 2020 · 1 comment

Comments

@ddur
Copy link

ddur commented Aug 16, 2020

Bug Report

Test case 1, Step 1

As first step, just upload JPEG image that is larger than your current setting for 'big_image_size_threshold' (default is 2560 pixels). That would trigger automatic SCALING of image, on upload (see function wp_create_image_subsizes() in image.php).
Make sure that your 'big_image_size_threshold' filter is not disabled or has value higher than your image pixel sizes.

Test case 2, Step 1

Another test would be to upload JPEG image with exif metadata [orientation] set to 2, 3 or 4. That would trigger automatic ROTATING of image on upload (see function wp_create_image_subsizes() in image.php), regardless of 'big_image_size_threshold'.

Further Test Steps for Test cases 1 & 2

Step 2: Edit the image (resize, rotate or flip etc) to get new metadata [sizes] set with edited images (where names are changed by new dimensions (WxH) and suffixing base-name with '-e' + 13 numeric characters).

Step 3: Regenerate the thumbnails.

Result: As far as I can read the code, edited image won't be attached anymore and in attachment metadata, edited thumbnails will be replaced with original thumbnails as created at upload.

Preconditions to be met:

This case is related only to NOT PNG ( == JPEG and maybe more?) type of images.

Original issue: Automattic/regenerate-thumbnails#102

Attn: @azaozz

@swissspidy
Copy link
Member

Steps, in other words, from Automattic/regenerate-thumbnails#102:

  • Upload a large JPG image. One dimension must be higher than 2560. It must be a JPG, not a PNG (it's possible that other formats have the same problem).
  • Edit the uploaded image (rotate or flip will make it most obvious).
  • Regenerate thumbnails for the image using this plugin.
  • After regenerating, the image in the Media Library is reverted to the pre-edited version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants