Changed to a mutch cleaner fix

wp-papi · Jun 4, 2015 · e10bf90 · e10bf90
1 parent 9bc3479
commit e10bf90
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/includes/properties/class-papi-property-relationship.php b/src/includes/properties/class-papi-property-relationship.php
@@ -66,6 +66,8 @@ public function get_sort_option( $post_id, $slug ) {
 	public static function get_sort_options() {
 		$sort_options = array();
 
+		$sort_options[__( 'Select', 'papi' )] = null;
+
 		$sort_options[__( 'Name (alphabetically)', 'papi' )] = function ( $a, $b ) {
 			return strcmp( strtolower( $a->post_title ), strtolower( $b->post_title ) );
 		};
@@ -150,11 +152,7 @@ public function html() {
 					<?php if ( $settings->show_sort_by ): ?>
 						<strong><?php _e( 'Sort by', 'papi' ); ?></strong>
 						<select name="_<?php echo $options->slug; ?>_sort_option">
-							<?php
-							$sort_options = array();
-							$sort_options[__( 'Select', 'papi' )] = '';
-							$sort_options = wp_parse_args( static::get_sort_options(), $sort_options );
-							foreach ( $sort_options as $key => $v ): ?>
+							<?php foreach ( static::get_sort_options() as $key => $v ): ?>
 								<option value="<?php echo $key; ?>" <?php echo $key == $sort_option ? 'selected="selected"' : ''; ?>><?php echo $key; ?></option>
 							<?php endforeach; ?>
 						</select>
@@ -215,7 +213,7 @@ public function sort_value( $value, $slug, $post_id ) {
 		$sort_option  = $this->get_sort_option( $post_id, $slug );
 		$sort_options = static::get_sort_options();
 
-		if ( empty( $sort_option ) || ! isset( $sort_options[$sort_option] ) ) {
+		if ( empty( $sort_option ) || ! isset( $sort_options[$sort_option] ) || is_null( $sort_options[$sort_option] ) ) {
 			return $value;
 		}