Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(global): ✨ add dimension component #418

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

PritamBag
Copy link
Member

Description

This dimension component helps us to get data related to windows, screen of the devices

Ref: #417

Related Issues

wrappid/styles#121

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers


Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

This dimension component helps us to get data related to window, screen of the devices

Ref: #417
@PritamBag PritamBag added the enhancement New feature or request label Nov 5, 2024
@PritamBag PritamBag requested a review from techoneel November 5, 2024 11:54
@PritamBag PritamBag self-assigned this Nov 5, 2024
@PritamBag PritamBag linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@techoneel techoneel merged commit 181c1fc into development Nov 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: need a dimension component
2 participants